Skip to content

bump openqasm version #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

bump openqasm version #40

merged 1 commit into from
May 14, 2025

Conversation

ajberdy
Copy link
Contributor

@ajberdy ajberdy commented Mar 31, 2025

Update to OpenQASM 1.0.1

@blakejohnson
Copy link

Can you tell us why you need to exclude 1.0.0?

@ajberdy
Copy link
Contributor Author

ajberdy commented May 14, 2025

Can you tell us why you need to exclude 1.0.0?

Openqasm 1.0.0 fails for array inputs (e.g. input array[int, 10] int_array_input) during parsing. This is fixed in openqasm/openqasm#581, which is part of 1.0.1

Previously, we only listed openpulse as a direct dependency, so this update would allow us to continue that pattern, instead of additionally specifying an openqasm constraint

@braised-babbage
Copy link
Collaborator

Looks good to me. @hodgestar do you want to review / merge?

@braised-babbage braised-babbage self-requested a review May 14, 2025 18:26
@hodgestar
Copy link
Contributor

Should we also update the grammar files? Perhaps it is not entirely necessary because inputs cannot be used inside cal or defcal blocks, but it seems consistent.

@ajberdy
Copy link
Contributor Author

ajberdy commented May 14, 2025

Should we also update the grammar files? Perhaps it is not entirely necessary because inputs cannot be used inside cal or defcal blocks, but it seems consistent.

The g4 file already defines inputs as supporting scalar or array types; is there another location you're referring to?

@hodgestar
Copy link
Contributor

Oh, perhaps it was already updated. Maybe even by me. :)

@hodgestar hodgestar merged commit 19e7fa0 into openqasm:main May 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants